Skip to content

linstor: implement missing deleteDatastore#10561

Merged
Pearl1594 merged 1 commit intoapache:4.19from
LINBIT:linstor-4.19-implement-missing-delete-datastore
Mar 18, 2025
Merged

linstor: implement missing deleteDatastore#10561
Pearl1594 merged 1 commit intoapache:4.19from
LINBIT:linstor-4.19-implement-missing-delete-datastore

Conversation

@rp-
Copy link
Contributor

@rp- rp- commented Mar 13, 2025 •
edited
Loading

Description

Somehow deleteDatastore was never implemented, that meant: templates haven't been cleaned up on datastore delete and also agents have never been informed about storage pool removal.
Fixes: #10465

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Adding/removing Linstor primary storage.

How did you try to break this feature and the system with this change?

@rp- rp- self-assigned this Mar 13, 2025
@rp- rp- linked an issue Mar 13, 2025 that may be closed by this pull request
[Linstor] Stop vm error after remove linstor primary storage and linstor controller #10465
Closed
@rp- rp- requested review from DaanHoogland and Pearl1594 March 13, 2025 10:34
@codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.28%. Comparing base (95c2481) to head (9496150).
Report is 5 commits behind head on 4.19.

❗ There is a different number of reports uploaded between BASE (95c2481) and HEAD (9496150). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (95c2481) HEAD (9496150)
unittests 1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.19   #10561       +/-   ##
=============================================
- Coverage     15.16%    4.28%   -10.88%     
=============================================
  Files          5414      368     -5046     
  Lines        474804    29656   -445148     
  Branches      57909     5207    -52702     
=============================================
- Hits          72002     1272    -70730     
+ Misses       394749    28239   -366510     
+ Partials       8053      145     -7908
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594 Pearl1594 added this to the 4.19.3 milestone Mar 13, 2025
DaanHoogland
DaanHoogland approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Pearl1594
Pearl1594 approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Pearl1594
Copy link
Contributor

Pearl1594 commented Mar 13, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 13, 2025

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 13, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12773

@rp-
linstor: implement missing deleteDatastore
9496150 
Somehow deleteDatastore was never implemented, that meant:
templates haven't been cleaned up on datastore delete and
also agents have never been informed about storage pool removal.
@rp- rp- force-pushed the linstor-4.19-implement-missing-delete-datastore branch from 001d144 to 9496150 Compare March 14, 2025 11:04
@rp- rp- requested review from DaanHoogland and Pearl1594 March 14, 2025 11:05
@rp-
Copy link
Contributor Author

rp- commented Mar 14, 2025

share the code now and did Daans suggestions

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Mar 14, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 14, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Pearl1594
Pearl1594 approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

blueorangutan commented Mar 14, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12785

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Mar 14, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Mar 14, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Mar 14, 2025

[SF] Trillian Build Failed (tid-12704)

@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025
@Pearl1594
Copy link
Contributor

Pearl1594 commented Mar 17, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Mar 17, 2025

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Mar 18, 2025

[SF] Trillian test result (tid-12725)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51664 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10561-t12725-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_secured_to_nonsecured_vm_migration Error 394.37 test_vm_life_cycle.py

@Pearl1594
Copy link
Contributor

Pearl1594 commented Mar 18, 2025

Merging based on test run - as there's no access to a setup to test this.

@Pearl1594 Pearl1594 merged commit f4a7c8a into apache:4.19 Mar 18, 2025
24 of 26 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Mar 18, 2025
@Pearl1594 Pearl1594 mentioned this pull request Mar 18, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@rp- @dhslove
linstor: implement missing deleteDatastore (apache#10561)
2fd5ff8 
Somehow deleteDatastore was never implemented, that meant:
templates haven't been cleaned up on datastore delete and
also agents have never been informed about storage pool removal.
@rp- rp- deleted the linstor-4.19-implement-missing-delete-datastore branch November 11, 2025 15:16
rp- added a commit to LINBIT/cloudstack that referenced this pull request Feb 24, 2026
@rp-
linstor: implement missing deleteDatastore (apache#10561)
b2f420b 
Somehow deleteDatastore was never implemented, that meant:
templates haven't been cleaned up on datastore delete and
also agents have never been informed about storage pool removal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

@rp- rp-

Labels

3rd-party:linstor component:primary-storage component:storage

Projects

ACS 4.20.1
Status: Done

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

[Linstor] Stop vm error after remove linstor primary storage and linstor controller

4 participants

@rp- @Pearl1594 @blueorangutan @DaanHoogland